On 07/11/2013 09:31 AM, Tom Rini wrote: > On Wed, Jul 10, 2013 at 03:06:02PM -0500, Dan Murphy wrote: > >> Add the tca642x gpio expander driver >> >> Datasheet: >> http://www.ti.com/product/tca6424a >> >> Signed-off-by: Dan Murphy <dmur...@ti.com> >> --- >> drivers/gpio/Makefile | 1 + >> drivers/gpio/tca642x.c | 322 >> ++++++++++++++++++++++++++++++++++++++++++++++++ >> include/tca642x.h | 66 ++++++++++ >> 3 files changed, 389 insertions(+) >> create mode 100644 drivers/gpio/tca642x.c >> create mode 100644 include/tca642x.h > Generally fine, but running checkpatch.pl: > total: 0 errors, 12 warnings, 2 checks, 395 lines checked > > NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX > MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE > USLEEP_RANGE > > /tmp/gpio1.mbox has style problems, please review. > > If any of these errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > So, please address those. > Yeah I ran cp on this file and when I looked @ it fixing the LTLs would have made the code look messy IMHO.
But I will fix it anyway and re-submit. -- ------------------ Dan Murphy _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
