Hi Axel, On Tue, Jul 2, 2013 at 10:24 PM, Axel Lin <axel....@ingics.com> wrote: > Use ARRAY_SIZE instead of having similar implementation in each drivers. > The NUMELEMS defined in drivers/net/npe/include/IxOsalTypes.h is not used > at all, so this patch removes it instead of converting it to use ARRAY_SIZE. > > Signed-off-by: Axel Lin <axel....@ingics.com> > Cc: Albert Aribaud <albert.u.b...@aribaud.net> > Cc: Ben Warren <biggerbadder...@gmail.com> > Cc: Jean-Christophe PLAGNIOL-VILLARD <plagn...@jcrosoft.com> > Cc: Joe Hershberger <joe.hershber...@ni.com> > Cc: Marek Vasut <ma...@denx.de> > Cc: Mike Frysinger <vap...@gentoo.org> > Cc: Nobuhiro Iwamatsu <iwama...@nigauri.org> > Cc: TsiChungLiew <tsi-chung.l...@freescale.com> > Cc: Wolfgang Denk <w...@denx.de> > Cc: York Sun <york...@freescale.com> > --- > v2: Fix checkpatch issues. (abandoned) > v3: Modified from v1, because v2 makes the patch bigger. > And using tab (which takes 8 spaces) as indent makes the code looks odd > because the whole file uses 4 spaces as indent. > Note, the checkpatch issue is not introduced by this patch itself, it's > because original source code does not pass checkpatch at all. > Address Marek's comment: > Remove NUMELEMS in drivers/net/npe/include/IxOsalTypes.h > because it is not used at all.
I agree that this is better than v2 in the scope of the patch. -Joe _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
