-----Original Message----- From: Tom Rini [mailto:tom.r...@gmail.com] On Behalf Of Tom Rini Sent: Thursday, June 27, 2013 1:35 AM To: Wood Scott-B07421 Cc: Zhang Ying-B40530; u-boot@lists.denx.de; aflem...@gmail.com; Wood Scott-B07421 Subject: Re: [U-Boot] [PATCH 06/10 v5] spl: env_common.c: make CONFIG_SPL_BUILD contain function env_import
On Wed, Jun 26, 2013 at 11:12:01AM -0500, Scott Wood wrote: > On 06/25/2013 09:29:37 PM, Zhang Ying-B40530 wrote: > > > > > >-----Original Message----- > >From: Wolfgang Denk [mailto:w...@denx.de] > >Sent: Friday, June 21, 2013 1:38 PM > >To: Zhang Ying-B40530 > >Cc: u-boot@lists.denx.de; Wood Scott-B07421; aflem...@gmail.com; > >Xie Xiaobo-R63061; Zhang Ying-B40530 > >Subject: Re: [U-Boot] [PATCH 06/10 v5] spl: env_common.c: make > >CONFIG_SPL_BUILD contain function env_import > > > >Dear ying.zh...@freescale.com, > > > >In message > ><1371715468-21120-6-git-send-email-ying.zh...@freescale.com> you > >wrote: > >> > >> The functionality env_import will be used in the SPL. They > >> had been excluded by ifndef CONFIG_SPL_BUILD. Now, put it > >> into the SPL. > >> > >> Signed-off-by: Ying Zhang <b40...@freescale.com> > >> --- > >> Compared with the original version, Changed as below: > >> 1. Split from "boot from SD card/SPI flash with SPL". > >> 2. Split from "spl: Make CONFIG_SPL_BUILD contain more > >functionality" > >> 3. No change. > >> 4. No change. > >> > >> common/env_common.c | 2 -- > >> 1 files changed, 0 insertions(+), 2 deletions(-) > > > >This affects all boards, all architectures? How well has this been > >tested? > >[Zhang Ying] > >May I suggest we define a new symbol CONFIG_SPL_ENV_IMPORT to contain > >the functionality "env_import"? > >So, "#ifndef CONFIG_SPL_BUILD" will be changed to > >"#if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_ENV_IMPORT)" > > Can we figure out if the ifdef is really needed first? Building for am335x_evm and am335x_evm_usbspl should tell you if it is, or is not. Whacking network support into SPL required more than --gc-sections alone could give us and we needed to drop a few couldn't-ever-reach calls and functionality out. [Zhang Ying] Yes, I tried to build for am335x_evm without this ifdef, no problem. Whether it can be removed? _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
