Frédéric Leroy <fr...@starox.org> writes: > Le 22/06/2013 17:31, Albert ARIBAUD a écrit : >> > However, the patch issues no warning at compile time and fixes the ide >> > block layer. >> >> OK -- anyone has any idea why Sasha's patch fixes reading from "far" >> blocks but does not fix ex2ls? Frankly, I'd prefer it if the patch >> fixed it all. :)
Thanks to Frédéric for testing and to Marek for the quick review. [...] > Ext2 code use "unsigned long" for the partition offset and "int" for > sector computation. > I will try to fix it, and try to test the other fs ( ext4, xfs, fat). > I would see one patch for the ide code, and one or more patch for the fs > code. > IMHO, Sascha patch can be applied as. While the IDE layer fix isn't enough for most use cases (storage devices in the TiB range are usually used with file systems rather than raw partitions), I agree that the file system level fixes should happen in separate patches. Tom, do you consider this a bug fix worth landing in v2013.07 or an intrusive change (possibly even a feature as it never worked before) that would go into v2013.10 instead? If it's considered a bug fix, it would probably be a good idea to land my patch ASAP rather than waiting for the FS level fixes. In the "feature" case we can wait and include both IDE and FS fixes in a single patch set once someone gets around to do the FS fixes. Sascha
pgphRl9hgGvO0.pgp
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
