Hi Simon, On Wed, Apr 17, 2013 at 10:35 AM, Tom Rini <tr...@ti.com> wrote: > On Mon, Mar 11, 2013 at 09:30:27AM -0700, Simon Glass wrote: > >> When building host utilities, we include libfdt.h from the host, not from >> U-Boot. This in turn brings in libfdt_env.h from the host, which can mess >> up the types and cause a build failure, depending on the host environment. >> To fix this, force inclusion of U-Boot's libfdt_env.h so that the types >> are correct. >> >> Another way to fix this is to use -nostdinc and -idirafter to ensure that >> system includes are included after U-Boot ones. Unfortunately this means >> that U-Boot's errno.h gets included instead of the system one. This in >> turn requires a hack to errno.h to redirect things, so all in all the >> solution in this patch is probably cleaner. >> >> Signed-off-by: Simon Glass <s...@chromium.org> > > Applied to u-boot/master, thanks! > > -- > Tom
For me this patch causes a regression that looks like this: Configuring for sandbox board... aisimage.c: In function âaisimage_generateâ: aisimage.c:314: warning: implicit declaration of function âgetlineâ imximage.c: In function âparse_cfg_fileâ: imximage.c:424: warning: implicit declaration of function âgetlineâ kwbimage.c: In function âkwdimage_set_ext_headerâ: kwbimage.c:236: warning: implicit declaration of function âgetlineâ pblimage.c: In function âpbl_parserâ: pblimage.c:119: warning: implicit declaration of function âgetlineâ ublimage.c: In function âparse_cfg_fileâ: ublimage.c:179: warning: implicit declaration of function âgetlineâ Did you not see this? I see it on ARM, PPC, and sandbox. -Joe _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
