Dear Daniel Schwierzeck,
In message <1370731370-32767-5-git-send-email-daniel.schwierz...@gmail.com> you
wrote:
> Move initialisation of Linux command line to separate functions.
> Also add support for bootm subcommand 'cmdline'.
> +static void linux_cmdline_dump(void)
> +{
> +#ifdef DEBUG
> + int i;
> +
> + printf("## cmdline argv at 0x%p, argp at 0x%p\n",
> + linux_argv, linux_argp);
> +
> + for (i = 1; i < linux_argc; i++)
> + printf(" arg %03d: %s\n", i, linux_argv[i]);
> +#endif
> +}
Please remove the #ifdef here, and change printf() into debug()
instead.
> + while (next && quote && quote < next) {
> + /* we found a left quote before the next blank
> + * now we have to find the matching right quote
> + */
Incorrect multiline comment style.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
IMPORTANT NOTICE TO PURCHASERS: The Entire Physical Universe, Inclu-
ding This Product, May One Day Collapse Back into an Infinitesimally
Small Space. Should Another Universe Subsequently Re-emerge, the
Existence of This Product in That Universe Cannot Be Guaranteed.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
