Hi Leo,
On 16/05/2013 18:13, SARTRE Leo wrote:
> +int board_init(void)
> +{
> + u32 reg;
> + /*Same init as the sabrelite*/
> + writel(0x41736166, SNVS_BASE_ADDR + 0x64);/*set LPPGDR*/
> + udelay(10);
> + reg = readl(SNVS_BASE_ADDR + 0x4c);
> + reg |= (1 << 3);
> + writel(reg, SNVS_BASE_ADDR + 0x4c);/*clear LPSR*/
Sorry that it was not checked before. Can you substitute fix constants
with useful defines ? Comment seems also deviant : it seems we can find
the same initialization in mx6qsabrelite.c, it is not. Please also
remove fix offsets when you access to the internal registres, and use C
structures instead. This is a must in u-boot, access with BASE + OFFSET
are not allowed.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
