On Wed, May 29, 2013 at 04:32:44PM +0530, Lokesh Vutla wrote: > From: Balaji T K <balaj...@ti.com> > > add dra mmc pbias support and ldo1 power on > > Signed-off-by: Balaji T K <balaj...@ti.com> > Signed-off-by: Lokesh Vutla <lokeshvu...@ti.com> [snip] > + udelay(150); /* wait 10 us */ > + value |= SDCARD_PWRDNZ; > + writel(value, (*ctrl)->control_pbias); > + udelay(150); /* wait 10 us */
That's not 10us.
> + val = 0x2b; /* (3 -.9)*20 +1 */
Consistent spacing in the math please (and leading 0).
> + if (palmas_i2c_write_u8(0x58, LDO1_CTRL, val)) {
No magic values please.
Thanks!
--
Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
