-----Original Message----- From: Wood Scott-B07421 Sent: Wednesday, May 22, 2013 11:46 PM To: Zhang Ying-B40530 Cc: Wood Scott-B07421; u-boot@lists.denx.de; aflem...@gmail.com; Xie Xiaobo-R63061; Ilya Yanok Subject: Re: [PATCH 5/6] spl: Make CONFIG_SPL_BUILD contain more functionality
On 05/21/2013 09:15:08 PM, Zhang Ying-B40530 wrote: > > diff --git a/include/configs/MPC8313ERDB.h > > b/include/configs/MPC8313ERDB.h > > index c28dfe0..a2bdcff 100644 > > --- a/include/configs/MPC8313ERDB.h > > +++ b/include/configs/MPC8313ERDB.h > > @@ -40,7 +40,9 @@ > > #define CONFIG_SPL_INIT_MINIMAL > > #define CONFIG_SPL_SERIAL_SUPPORT > > #define CONFIG_SPL_NAND_SUPPORT > > +#ifdef CONFIG_SPL_BUILD > > #define CONFIG_SPL_NAND_MINIMAL > > +#endif > > #define CONFIG_SPL_FLUSH_IMAGE > > #define CONFIG_SPL_TARGET "u-boot-with-spl.bin" > > #define CONFIG_SPL_MPC83XX_WAIT_FOR_NAND > > diff --git a/include/configs/P1022DS.h b/include/configs/P1022DS.h > > index 8b13b10..5bdd44a 100644 > > --- a/include/configs/P1022DS.h > > +++ b/include/configs/P1022DS.h > > @@ -41,7 +41,9 @@ > > #define CONFIG_SPL_INIT_MINIMAL > > #define CONFIG_SPL_SERIAL_SUPPORT > > #define CONFIG_SPL_NAND_SUPPORT > > +#ifdef CONFIG_SPL_BUILD > > #define CONFIG_SPL_NAND_MINIMAL > > +#endif > > #define CONFIG_SPL_FLUSH_IMAGE > > #define CONFIG_SPL_TARGET "u-boot-with-spl.bin" > > > > diff --git a/include/configs/p1_p2_rdb_pc.h > > b/include/configs/p1_p2_rdb_pc.h > > index 7ed634b..bc48d62 100644 > > --- a/include/configs/p1_p2_rdb_pc.h > > +++ b/include/configs/p1_p2_rdb_pc.h > > @@ -159,7 +159,9 @@ > > #define CONFIG_SPL_INIT_MINIMAL > > #define CONFIG_SPL_SERIAL_SUPPORT > > #define CONFIG_SPL_NAND_SUPPORT > > +#ifdef CONFIG_SPL_BUILD > > #define CONFIG_SPL_NAND_MINIMAL > > +#endif > > #define CONFIG_SPL_FLUSH_IMAGE > > #define CONFIG_SPL_TARGET "u-boot-with-spl.bin" > > Are you sure this belongs in this patch? > [Zhang Ying] > Yes, it is necessary. Because CONFIG_SPL_NAND_MINIMAL has been used > in the file law.c and tlb.c in this patch. What I mean is that it should probably have been done earlier, when you introduced CONFIG_SPL_NAND_MINIMAL. [Zhang Ying] I can understand you mean. Because the symbol "CONFIG_SPL_NAND_MINIMAL" has been useless, I think no need to split out a separate patch. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
