Dear "SARTRE Leo",

In message <3465d313fdfb824f9a9c8cd24fa4f6bc0108c...@frontmail.adetel.com> you 
wrote:
>
> I will rework my patch taking all your remarks, and those from Wolfgang, into 
> acount, I just like to talk a bit about the problem of duplicated code that 
> you spooted. 
> This patch is just a first commit for this board, there will come other 
> commits 
> to add missing functionnalities provided by the board, so I think that it 
> will 
> be more convenient to have a separate file even if for now, it is very 
> similar 
> to the sabrelite file. 

NAK.  Duplicating code is NEVER a good idea.  Even if you want to add
other / more stuff, then it makes a lot of sense to factor out the
common parts into a common file.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The human race is a race of cowards; and I am not  only  marching  in
that procession but carrying a banner.                   - Mark Twain
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to