Hi, > The changes look good to me. 2 comments below: > >> +/* >> + * Keep for now for backward compatibility; >> + * remove later when support for "autoscr" goes away. >> + */ >> +U_BOOT_CMD( >> + autoscr, 2, 0, do_source, >> + "run script from memory", >> + "[addr] - run script starting at addr" >> + " - A valid image header must be present\n" >> +#if defined(CONFIG_FIT) >> + "For FIT format uImage addr must include subimage\n" >> + "unit name in the form of addr:<subimg_uname>\n" >> +#endif >> +); > > I'd vote to change autoscr's help messages to something letting end > user's know that the command is deprecated and being replaced by the > "source". Eg something like: > > + autoscr, 2, 0, do_source, > + "DEPRECATED - see 'source' command", > + "DEPRECATED - see 'source' command" > > Most U-Boot user's are more likely to see this than the > feature-removal-schedule.txt in the source code.
Actually I also like that, but if we head down this direction, then why not go all the way and print a warning on executing autoscr? Thinking about it (and reflecting on how I interact with U-Boot), I fear that even the help message will not get too much attention from people who should get aware of the problem. What do other people think about this? Cheers Detlev -- 14474011154664524427946373126085988481573677491474835889066354349131199152128 If you know why this number is perfect - you're probably a mathematician... -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
