Hi Tom,

On Mon, May 06, 2013 at 05:02:12PM +0200, Dirk Eibach wrote:
Hi Tom,

On Mon, May 06, 2013 at 04:07:15PM +0200, Wolfgang Denk wrote:
Dear dirk.eib...@gdsys.cc,

In message
<1367847325-21463-5-git-send-email-dirk.eib...@gdsys.cc> you
wrote:

...
+                       fpga_set_reg(k, REG(reflection_low),
+                                    REFLECTION_TESTPATTERN);

This breaks bisecting. You reference functions which you only add in
a later patch.

Note that 'git rebase -i' and the exec keyword can help you test
bisectability.

I know 'git rebase -i', but what is the exec keyword? It seems there
is some room for improvement on patman :)

Well, it's a rebase command.  In addition to
pick/edit/reword/squash/fixup you can do 'exec make sandbox', or more
likely some script that builds a bunch of things and returns non-zero on
failure.  Git will then run that command at that point in the rebase
(say, pick the first commit, exec) and if the exec fails, you get
dropped to a command prompt and can edit the previous commit, etc.

Wow, that's a very nice tool. I will pick it into my workflow.

Cheers
Dirk
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to