Hi Wolfgang,
On 04.04.2013 14:46, Wolfgang Denk wrote:
> In message <1365059554-10662-1-git-send-email...@denx.de> you wrote:
>> Sometimes it might make sense to verify the written data to NOR flash.
>> This patch adds this feature. To enable this verify-after-write, you
>> need to define CONFIG_SYS_FLASH_VERIFY_AFTER_WRITE in your board
>> config header.
>>
>> Signed-off-by: Stefan Roese <s...@denx.de>
>> ---
>> common/flash.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>
> This is a user selectable feature, thus the option should be
> CONFIG_FLASH_VERIFY_AFTER_WRITE. Thinking about it - obviously you
> cannot verify _before_ the write, so all the "after write" is
> redundant. Better call it just "CONFIG_FLASH_VERIFY". Please also
> change the error message:
>
> Instead
>
> printf("\nVerify-after-write failed!\n");
>
> just:
>
> printf("\nVerify failed!\n");
>
> Finally - you are introducing a new CONFIG_ option; this must be
> documented in the README.
>
> And it might make sense to add a comment that this option is totally
> useless in almost all cases, and should only be enabled if you know
> EXACTLY what you are doing - and that it does not really work even
> then.
Thanks for your review. Everything you mentioned makes perfect sense.
I'll address those issues in v2 of the patch.
Thanks,
Stefan
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
