On Sun, Mar 24, 2013 at 10:51:33PM +0100, Peter Korsgaard wrote:

> Jump into full u-boot mode if a 'c' character is received on the uart.
> 
> We need to adjust the spl bss/malloc area to not overlap with the
> loadaddr of the kernel (sdram + 32k), so move it past u-boot instead.
> 
> Signed-off-by: Peter Korsgaard <peter.korsga...@barco.com>
[snip]
> +/* raw mmc */
> +#define CONFIG_SYS_MMCSD_RAW_MODE_KERNEL_SECTOR      0xa00 /* address 
> 0xa0000 */
> +#define CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR        0x8   /* address 0x1000 
> */
> +#define CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTORS       8     /* 4KB */

Did you also test raw mode?  Also, why 0xa00?  U-Boot is 0x300 -> 0x500,
and one might say throw a redundant copy at 0x500 -> 0x700.  But we
don't do 4 copy redundancy in U-Boot, just 2 usually.

> +/* dummy defines to keep spl_nand.c happy */
> +#define CONFIG_CMD_SPL_NAND_OFS                      0
> +#define CONFIG_SYS_NAND_SPL_KERNEL_OFFS              0
> +#define CONFIG_CMD_SPL_WRITE_SIZE            0

We should do some real defines here while at it, since the GP EVM has
NAND :)

-- 
Tom

Attachment: signature.asc
Description: Digital signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to