Dear Detlev Zundel,
In message <m23ad2rmh2....@ohwell.denx.de> you wrote:
>
> >> @@ -235,6 +238,23 @@ int misc_init_f (void)
> >> *(vu_long *) MPC5XXX_WU_GPIO_ENABLE |= GPIO_PSC3_9;
> >> *(vu_long *) MPC5XXX_WU_GPIO_DIR |= GPIO_PSC3_9;
> >> *(vu_long *) MPC5XXX_WU_GPIO_DATA_O |= GPIO_PSC3_9;
> >
> > You don't want to fix the missing accessor functions here, do you? ;-)
>
> Oh I do - actually, I did - please check my later posting "inka4x0: Use
> proper accessor macros for memory mapped registers."
>From the reviewing point of view it would have been easier if that
other patch would have come earlier in the sequence. As is, it is
really difficult to see if the lines above are included in your other
patch, or if they might have been missed. Keep in mind that reviewing
is a sequential process...
But OK, from the end result it makes no difference.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Yes, it is written. Good shall always destroy evil.
-- Sirah the Yang, "The Omega Glory", stardate unknown
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
