On Mon, Mar 23, 2009 at 10:55 PM, Jon Smirl <jonsm...@gmail.com> wrote:
>>> +/*
>>> + * Returns OPENIP register base address. First thing called in the driver.
>>> + */
>>> +unsigned int board_video_init(void)
>>> +{
>>> + ulong dummy;
>>> + dummy = in_be32((unsigned __iomem *)OPENIP_MMIO_BASE); /*dummy read
>>> */
>>> + dummy = in_be32((unsigned __iomem *)OPENIP_MMIO_BASE); /*dummy read
>>> */
>>> + return OPENIP_MMIO_BASE;
>>> +}
>>
>> I asked before what these dummy reads are supposed to be good for.
>>
>> This looks like a sleeping problem to me.
>>
>
> I don't own this OpenIP video hardware and I didn't write this code. I
> don't work for Phytec or Pengutronix; I'm just a customer. I needed
> some newer features from the current u-boot and I had to port
> Pengutronix's release of u-boot 1.2 up to current git head. I want to
> get this code included in u-boot so it won't get stale again.
>
> If you want I can just delete the support for CONFIG_VIDEO_OPENIP.
Pengutronix guys have confirmed that it ok to drop the video_openip support.
I'll post a new patch.
>
> --
> Jon Smirl
> jonsm...@gmail.com
>
--
Jon Smirl
jonsm...@gmail.com
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
