On Wed, Feb 20, 2013 at 02:05:46PM -0700, Tom Warren wrote: > This patchset adds device-tree support to the Tegra MMC driver. > All device config is done via properties in the DT files instead > of hard-coded config options/function arguments. > > I've tested this on my Seaboard and everything works fine, > including card detect. For the other T20 boards, I've used > the Linux kernel DTS files for the sdhci nodes where there > wasn't one already, or expanded the info that was already > there. Everything builds fine, but I haven't tested anything > but Seaboard. > > v2: Changes as per Stephen's & Simon's review > v3: Changes as per Stephen/Lucas/Thierry/Simon's feedback > v4: Additional changes as per Stephen/Lucas/Thierry/Simon > v5: Additional changes as per Stephen/Lucas/Andy
Hi Tom, Joseph Lo posted some patches recently which make changes to the Linux driver to use common MMC code. This results in the third cell of the GPIO specifier to actually become meaningful. That is, boards now need to define the CD GPIO as low-active in order for card-detection to work properly. I wonder if we should be integrating similar changes into this patch series. fdtdec_get_gpio() seems to already support that functionality, so I think the only changes necessary would be to change the third cell in the specifier and make tegra_mmc_getcd() return fdtdec_get_gpio() instead of !fdtdec_get_gpio(). Does that sound like something you'd be willing to integrate with this series? Thierry
pgp4m5hSo_6jt.pgp
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot