On Tue, Feb 19, 2013 at 10:16 PM, Eric Nelson <eric.nel...@boundarydevices.com> wrote: > On 02/19/2013 05:42 PM, Otavio Salvador wrote: >> >> On Tue, Feb 19, 2013 at 8:03 PM, Eric Nelson >> <eric.nel...@boundarydevices.com> wrote: >>> >>> Hi Otavio, >>> >>> >>> On 02/19/2013 01:30 PM, Otavio Salvador wrote: >>>> >>>> >>>> On Tue, Feb 19, 2013 at 5:12 PM, Eric Nelson >>>> <eric.nel...@boundarydevices.com> wrote: >>>>> >>>>> >>>>> Hi Stefano, >>>>> >>>>> This seems to have gotten lost in the shuffle. >>>>> >>>>> It's showing as "Changes requested" in Patchwork: >>>>> >>>>> http://patchwork.ozlabs.org/patch/186280/ >>>>> >>>>> Is there something you'd like changed? >>>>> >>>>> Please advise, >>>> >>>> >>>> >>>> I'd say to use space between the '+' as done in other code. >>>> >>> >>> I must be dense. >>> >>> Which '+' needs a space? >> >> >> It seems usually when dealing with offsets we have ' + '. Personally I >> think it is clear to read too. But it's not my call so it is up to you >> and Stefano. >> > Gotcha. > > You mean here: > > +{ > + u8 reg = __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0); > ^ > > That's the trouble with commenting on the patchwork link...
Yes; a space between both macros. -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
