On Wed, Feb 13, 2013 at 7:39 PM, Fabio Estevam <feste...@gmail.com> wrote: > On Wed, Feb 13, 2013 at 7:36 PM, Otavio Salvador > <ota...@ossystems.com.br> wrote: >> On Wed, Feb 13, 2013 at 7:31 PM, Fabio Estevam <feste...@gmail.com> wrote: >>> On Wed, Feb 13, 2013 at 7:20 PM, Otavio Salvador >>> <ota...@ossystems.com.br> wrote: >>> >>>>>> #ifdef CONFIG_MX23 >>>>>> + /* Enable tRAS lockout in HW_DRAM_CTL08 ; it must be after all */ >>>>> >>>>> 'After all'? >>>> >>>> For me it is clear enough; I am not native so it'd be good if a native >>>> English speaker could comment on this. >>> >>> I think you meant to say "it must be the last element". >> >> diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c b/arch/arm/cpu/arm926 >> index f8392f6..b6a0563 100644 >> --- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c >> +++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c >> @@ -119,6 +119,9 @@ static void initialize_dram_values(void) >> writel(dram_vals[i], MXS_DRAM_BASE + (4 * i)); >> >> #ifdef CONFIG_MX23 >> + /* Enable tRAS lockout in HW_DRAM_CTL08 ; it must be the last >> + * element to be set */ > > I think the comment is clear, but multi-line comment should be like: > > /* > * First line bla bla bla > * Second line bla bla bla > */
Ok; fixed for v3. -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
