On Mon, Jan 28, 2013 at 2:16 PM, Marek Vasut <ma...@denx.de> wrote: > Dear Otavio Salvador, > >> On Mon, Jan 28, 2013 at 1:57 PM, Marek Vasut <ma...@denx.de> wrote: >> > Dear Otavio Salvador, >> > >> > Missing commit message. >> >> I think short description is clear enough. What you'd like me to put >> in long one? > > Reasoning why this patch is necessary.
Well, it seems quite clear it fix a build failure when it is used in assembly stage; it is clear enough for me, in the shortlog >> >> Signed-off-by: Otavio Salvador <ota...@ossystems.com.br> >> >> --- >> >> Changes in v4: >> >> - New patch >> >> >> >> Changes in v3: None >> >> Changes in v2: None >> >> >> >> arch/arm/include/asm/arch-mxs/iomux.h | 5 +++++ >> >> 1 file changed, 5 insertions(+) >> >> >> >> diff --git a/arch/arm/include/asm/arch-mxs/iomux.h >> >> b/arch/arm/include/asm/arch-mxs/iomux.h index 7abdf58..4288715 100644 >> >> --- a/arch/arm/include/asm/arch-mxs/iomux.h >> >> +++ b/arch/arm/include/asm/arch-mxs/iomux.h >> >> @@ -21,6 +21,10 @@ >> >> >> >> #ifndef __MACH_MXS_IOMUX_H__ >> >> #define __MACH_MXS_IOMUX_H__ >> >> >> >> +#ifndef __ASSEMBLY__ >> >> + >> >> +#include <asm/types.h> >> >> + >> > >> > Is this needed? >> >> Yes; or I would not have added it right? :) > > Why is it needed? > >> >> /* >> >> >> >> * IOMUX/PAD Bit field definitions >> >> * >> >> >> >> @@ -165,4 +169,5 @@ int mxs_iomux_setup_pad(iomux_cfg_t pad); >> >> >> >> */ >> >> >> >> int mxs_iomux_setup_multiple_pads(const iomux_cfg_t *pad_list, unsigned >> >> >> >> count); >> >> >> >> +#endif /* __ASSEMBLY__ */ >> >> >> >> #endif /* __MACH_MXS_IOMUX_H__*/ >> > >> > Best regards, >> > Marek Vasut >> >> -- >> Otavio Salvador O.S. Systems >> E-mail: ota...@ossystems.com.br http://www.ossystems.com.br >> Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br > > Best regards, > Marek Vasut -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
