Dear Amarendra Reddy,
In message <CAPbRUm=2t8=mojzewv98eq15nv8rqo0sbjxwm7mzj+zft2q...@mail.gmail.com>
you wrote:
>
> Thanks for the review comments.
> I would like to clarify that this patch resizes EMMC partitions. But does
> not create partitions.
> I think the statement *"..close and create partitions on EMMC"* was
> misleading, which I corrected in latest patch set.
>
> The EMMC4.4 chips are provided with 2 boot partitons and 1 RPMB partition.
> This patch merely deals with resizing Boot partitions & RPMB partition, by
> sending proper commands to EMMC chip.
I see, but I still think that instead of adding (E)MMC specific
partition handling, we should instead start and add a generc command
to create/change/delete partitions, and then provide the (E)MMC
specific implementation for it. This way we can later add partition
handling for other storage media if someone needs this. Otherwise we
would have a growing number of completely separate implementations,
with incomplatible user interfaces and all the other maintenance
nightmares this would cause.
That means the core of your implementation will remain the same, just
the command interface should be made generic so it can be extended to
add support for other storage devices.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
"We all agree on the necessity of compromise. We just can't agree on
when it's necessary to compromise."
- Larry Wall in <1991nov13.194420.28...@netlabs.com>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
