-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/17/12 13:53, Scott Wood wrote: > On 12/17/2012 08:52:59 AM, Tom Rini wrote: >> On Fri, Dec 14, 2012 at 06:54:05PM -0600, Scott Wood wrote: >> >>> SPL doesn't use the environment. These list entries prevent >>> the functions from being garbage-collected, even though nothing >>> will >> look at >>> the list. This caused several SPL builds (e.g. >>> P2020RDB-PC_NAND) to break due to size limitations. >> >> SPL with networking support uses the environment, so you need to >> toss CONFIG_SPL_NET_SUPPORT into the test. That said, it's not >> an interactive environment and this might push that area over the >> size limit too (in the USB case, which is already pretty tight). > > OK, I saw "env_*" stuff in the "ifndef CONFIG_SPL_BUILD" section, > but later some of it shows up in "ifdef CONFIG_SPL_BUILD" as well. > > So, do you want a v2, or is it OK because it's not interactive? In > the latter case should env_callback.o be removed from the SPL > build?
Lets do a v2 (since the commit message would have been wrong) and add in a comment saying SPL doesn't have interactive environment, so we don't need this code. > Also, env_nvedit.o, env_common.o, and env_flash.o are included for > SPL regardless of CONFIG_SPL_NET_SUPPORT. In fact it looks like > env_nvedit.o will be included twice if CONFIG_SPL_NET_SUPPORT is > enabled. :-P Since I'd assume 'sort' in make isn't sort -u, I'm not sure how it's filtering out the dupes unless we don't really need it afterall, am335x_evm builds with CONFIG_SPL_NET_SUPPORT enabled. I'm curious now, so I'm poking it. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQIcBAEBAgAGBQJQz26oAAoJENk4IS6UOR1WpL0QAJY0PussCOcq+B4Rr2eagtQj e4glJMGst//JKi8hhGac35QhbyAXIJJDO++QET6PUxItUs+ltPci9884gSfe3wvp 6mSB3UKtKVHhMckcVptOTDhrDqwBCDBUFEPKosONJTYRP0s0vOj3E92bAU+z0CJ4 JyVj94lEvstdNxUKHKxRsxu6PF+okSOb/q9X0efx/boxeuyqPUoT15B0zNrtz4kd G31Efjy0sP1HrSp73zvSFoVV2N6p+MbKoFJgxM8seRg+JsPRj7DYCnuGn1l/Hj9m vc+2UMsf9az8+p1333QejYgtFYEmcvrwXXrp4Dcg2e1DCD2mEpmVtCkdI3SFdKvs CbHUuJ9Uc3CACjo4TtH5V7ZiiDwC8+gsO1ucxmng7/Ezr1XCFLOs4nJZKTUXiqwh ZBXaGaApBTCi8vClPyH6jYycjgnKIT3R5bcWIjD8ArhpOypy1J3V2/xqqCJhmyzD gZa1Ym0NXnJ2bSdu2RWcYGyGOt9BLdlpr3nMb03ZdRr2jiy3KktGh2gptDGhz8jk HQ9IS3jUXEQK4QD+UoKYdNfUSbC3G6e6ISM8otCHDVQO4cef/04bT3sBnvo/oUwD RiBSxEDE/Gs9m4UHRuroI3bS+bqNjjdmQXSnq39cST3z+y6qMs7TpkN0iHKWoikz /d7+lr2MD61cneVS5/cj =kOOU -----END PGP SIGNATURE----- _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
