Dear Simon Glass, > Hi, > > On Thu, Dec 13, 2012 at 9:32 AM, Marek Vasut <ma...@denx.de> wrote: > > Dear Simon Glass, > > > >> From: Patrick Georgi <patr...@georgi-clan.de> > >> > >> Interrupt transfers aren't meant to be used from the async list > >> (the EHCI spec indicates trouble with low/full-speed intr on async). > >> > >> Build a periodic list instead, and provide an API to make use of it. > >> Then, use that API from the existing interrupt transfer API. > >> > >> This provides support for USB keyboards using EHCI. > >> > >> Signed-off-by: Patrick Georgi <patr...@georgi-clan.de> > >> Signed-off-by: Simon Glass <s...@chromium.org> > > > > [...] > > > > Looks good in general. Clear up those ToDos please. Also, some while() > > cycles are endless, make use of some timeout please. > > Not much ability to do anything other than remove them... > > The timeouts come in the next patch - should I squash them?
Yeah, squash them. Was there any reason to split them ? Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
