Hi Rajeshwari, On Mon, Dec 10, 2012 at 3:55 AM, Rajeshwari Shinde <rajeshwar...@samsung.com> wrote: > Moved the pmic_max77686.c max77686_pmic.h to drivers/power > and made required changes accordingly > > Signed-off-by: Rajeshwari Shinde <rajeshwar...@samsung.com>
Acked-by: Simon Glass <s...@chomium.org> See nit below if you end up resending. You might consider using the -M option to git format-patch which detects renames. Or you could use patman... > --- > drivers/misc/pmic_max77686.c | 42 ---------- > drivers/power/pmic/Makefile | 1 + > drivers/power/pmic/pmic_max77686.c | 48 +++++++++++ > include/max77686_pmic.h | 158 > ------------------------------------ > include/power/max77686_pmic.h | 158 > ++++++++++++++++++++++++++++++++++++ > 5 files changed, 207 insertions(+), 200 deletions(-) > delete mode 100644 drivers/misc/pmic_max77686.c > create mode 100644 drivers/power/pmic/pmic_max77686.c > delete mode 100644 include/max77686_pmic.h > create mode 100644 include/power/max77686_pmic.h > > diff --git a/drivers/misc/pmic_max77686.c b/drivers/misc/pmic_max77686.c > deleted file mode 100644 > index 36f7f4d..0000000 [snip] \ > +++ b/drivers/power/pmic/pmic_max77686.c > @@ -0,0 +1,48 @@ > +/* > + * Copyright (C) 2012 Samsung Electronics > + * Rajeshwari Shinde <rajeshwar...@samsung.com> > + * > + * See file CREDITS for list of people who contributed to this > + * project. > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, > + * MA 02111-1307 USA > + */ > + > +#include <common.h> > +#include <power/pmic.h> > +#include <power/max77686_pmic.h> > +#include <errno.h> I think this should go above the power/ headers, below common. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot