From: Vincent Palatin <vpala...@chromium.org>

The name is already copied when we memcpy() the whole structure.

This is because struct stdio_dev has this field:

        char    name[16];               /* Device name                          
*/

So the data is inline, rather than being a pointer.

Signed-off-by: Vincent Palatin <vpala...@chromium.org>

Signed-off-by: Simon Glass <s...@chromium.org>
---
Changes in v3: None
Changes in v2:
- Add more comments to the stdio strncpy commit message

 common/stdio.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/common/stdio.c b/common/stdio.c
index 9f48e5f..97ff9cf 100644
--- a/common/stdio.c
+++ b/common/stdio.c
@@ -135,7 +135,6 @@ struct stdio_dev* stdio_clone(struct stdio_dev *dev)
                return NULL;
 
        memcpy(_dev, dev, sizeof(struct stdio_dev));
-       strncpy(_dev->name, dev->name, 16);
 
        return _dev;
 }
-- 
1.7.7.3

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to