Hi Tom, On Mon, Nov 26, 2012 at 12:03 PM, Tom Rini <tr...@ti.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 11/22/12 14:42, Simon Glass wrote: >> Hi Wolfgang, >> >> On Thu, Nov 22, 2012 at 11:10 AM, Simon Glass <s...@chromium.org> >> wrote: >>> Hi Wolfgang, >>> >>> On Mon, Nov 19, 2012 at 11:14 PM, Wolfgang Denk <w...@denx.de> >>> wrote: >>>> Dear Tom, >>>> >>>> In message <1351960246-31771-1-git-send-email...@denx.de> you >>>> wrote: >>>>> The TPM code was added more than a year or 4 releases ago. >>>>> This was done under the proposition that board support that >>>>> would actually use such code would be added soon. However, >>>>> nothing happened since. The code has no users in mainline, >>>>> and does not even get build for any configuration, so we >>>>> cannot even tell if it compiles at all. >>>>> >>>>> Remove the unused code. In in some far future actual users >>>>> show up, it can be re-added easily. >>>>> >>>>> Signed-off-by: Wolfgang Denk <w...@denx.de> Cc: Vadim >>>>> Bendebury <vben...@chromium.org> Cc: Simon Glass >>>>> <s...@chromium.org> --- README | 10 - >>>>> common/Makefile | 1 - common/cmd_tpm.c | 103 >>>>> --------- doc/driver-model/UDM-tpm.txt | 48 ---- >>>>> drivers/tpm/Makefile | 43 ---- drivers/tpm/generic_lpc_tpm.c >>>>> | 495 ------------------------------------------ >>>>> include/tpm.h | 71 ------ 7 files changed, 771 deletions(-) >>>>> delete mode 100644 common/cmd_tpm.c delete mode 100644 >>>>> doc/driver-model/UDM-tpm.txt delete mode 100644 >>>>> drivers/tpm/Makefile delete mode 100644 >>>>> drivers/tpm/generic_lpc_tpm.c delete mode 100644 >>>>> include/tpm.h >>>> >>>> This was sent before end of the merge window, but has not been >>>> applied yet. >>>> >>>> Despite some discussion about why having TPM code is generally >>>> useful, there are still no actual users for it visible, so I >>>> really would like to see this patch applied. >>>> >>>> It is trivial to re-activate this code if actual users for it >>>> should be added some day to come. >>> >>> For what it is worth, this is a NAK from me. There is a patch >>> pending for the next release to enable this for coreboot, and >>> another driver for an i2c TPM driver for the ARM Chromebook also >>> pending, also within the merge window. The TPM support here is >>> light but it is a start, and reverting it seems to serve no >>> purpose (I am happy to maintain the code if it needs work, e.g. >>> for device model). On the contrary this code provides a base on >>> which verified boot can be built, and provides useful functions >>> for talking to a TPM which may be on others boards as well. >> >> Part of the reason why the TPM was never turned on in coreboot was >> the difficulty in upstreaming the code, which resulted in us >> giving up about a year ago. That effort has since restarted and I >> am hopeful that it will be successful. >> >> Perhaps as a compromise we could have one more cycle to create a >> verified boot which uses the TPM drivers, which I think is what is >> required here? The timing is good at this end to actually do the >> work. >> >> That would send that right signal that this work is valued >> upstream. That is a very important signal. > > I can see where Wolfgang's frustration comes from here. So yes, > you've got until v2012.04-rc1 comes out (which will be ~2 weeks after > v2013.01 is out) before I pull Wolfgang's patch to have posted a > series that makes use of this (which is to say, you have until the end > of the merge window for the next release to have something that is > mergeable for the release).
OK that seems reasonable, it gives me time to make this happen. Thank you both, Simon > > - -- > Tom > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.11 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ > > iQIcBAEBAgAGBQJQs8sVAAoJENk4IS6UOR1Wyt0P/2GZMc3RAt/3ZC5SaB/lLVG6 > UACxxvWfGWDg7QaYxLokNkbMQfnKNQMGCCrMRbNiU7A5rjbRN+6IeaB7kpQ0CQN3 > 1SUKcdk2hZSpLXH6KGRg4l7i/0MohKyp1tX2qkLJs4ojwAfbcYO3v+Pz+QIuMcz+ > rqURzArPOoHA/7yq4WPkQrB820Y8nelQFYo4w1DJ+cEtZ6c1gWJSLj0LAprj8ZcD > DVHYtITA2K3d7SS0dm3TjNwwHXrSuOZ1n/+SQURqQ87nUxRiLdd7W54rPyeB58H7 > lRst0AC6y1yPBTL30U898HrWg1owF5r4fTNp+/Qwr2rGG5C4ClnHCkS5vvMYc0J4 > hSDPya5z5rv7zQQ4xa2t4lvjZdj+ZQ1hafQfaCJB9+sHs6Qz49MJzKpwLR0cLy6u > 9Sl27LskphVXmJ9YosrSlGWjh+RSFoJZhV7hlUpaU3Kvd9qNHafrJvUj8MlCaTuU > yFbfO71J88dsIJZlTTSuGQ3NTf5cYNySe91EW7JSGcW4B+IkpTGVb1crxxpzaw0B > LTkCT9Sc9AkJezfi4C/a/66bLoaQ3ugtFcsEuk641jiCnlsQvHjNsg6vzgJQ+8NX > Cbs5a0lzpUUtFLALyrTakHi6/99SsP20Ez8/p3U9+2FS0xD9XDyiqCf7fxZf48Ek > bnafmm4U+kmyhs0i9FzU > =IDf8 > -----END PGP SIGNATURE----- _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
