Hi Mike, wow, that a more rapid response that I am used to :)
Mike Frysinger wrote: > On Friday 20 February 2009 11:34:06 Richard Retanubun wrote: >> From e2e085f8b8e638762c59b0bc5376b241b0046132 Mon Sep 17 00:00:00 2001 >> From: Richard Retanubun <[email protected]> >> Date: Fri, 20 Feb 2009 11:06:36 -0500 >> Subject: [PATCH] Cleanup the comment for m68k linux boot argument passing. >> >> >> Signed-off-by: Richard Retanubun <[email protected]> >> --- >> Hi Tsi-Chung, >> >> Thanks for the response, I found the solution after using a hw debugger to >> step through the code. The one gotcha here is that the assembly instruction >> that the compiler uses to jump to the kernel is 'jsr' which puts the next >> instruction after the jsr into the stack pointer so there is an >> 'off-by-one' effect from the stack pointer. >> >> This patch cleans up the comment to clarify the boot arg passing. >> I'll try to push a patch for the kernel as well. > > comments for the changelog go above the ---, not below Yep, I thought this is what I did, the commit message is "Cleanup the comment for m68k linux boot argument passing." The stuff under the --- Is just continuing a conversation thread. I tend to keep the commit message short and be more verbose in the code comments. > > use git and put it into the commit message: > $ git commit --amend Thanks for the tip. I'll submit a V2. > blah blah the patch summary > > a paragraph about the changes .... > -mike _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
