On Feb 18, 2009, at 3:20 PM, Kim Phillips wrote: > On Tue, 17 Feb 2009 15:54:52 -0600 > Timur Tabi <ti...@freescale.com> wrote: > >> On Tue, Feb 17, 2009 at 3:49 PM, Kumar Gala <ga...@kernel.crashing.org >> > wrote: >>> The default value is 256M so I don't thing the change is need >>> anymore. >> >> Huh? I think his patch is supposed to address the fact that 256MB is >> the limit, and he wants to add more. > > so this commit started producing warnings for boards that defined > their > own CONFIG_MAX_MEM_MAPPED, such as the SIMPC8313 (with 512MB): > > commit 87c9063963561d3d01064be34d0c30855a56587b > Author: Kumar Gala <ga...@kernel.crashing.org> > Date: Thu Feb 5 20:40:58 2009 -0600 > > ppc: Move CONFIG_MAX_MEM_MAPPED to common config.h > > Moved CONFIG_MAX_MEM_MAPPED to the asm/config.h so its kept > consistent > between the two current users (lib_ppc/board.c, 44x SPD DDR2). > > Signed-off-by: Kumar Gala <ga...@kernel.crashing.org> > Acked-by: Stefan Roese <s...@denx.de> > > the warnings are: > > In file included from /home/r1aaha/git/u-boot/include/config.h:5, > from /home/r1aaha/git/u-boot/include/common.h:35, > from simpc8313.c:26: > /home/r1aaha/git/u-boot/include/configs/SIMPC8313.h:81:1: warning: > "CONFIG_MAX_MEM_MAPPED" redefined > In file included from /home/r1aaha/git/u-boot/include/config.h:4, > from /home/r1aaha/git/u-boot/include/common.h:35, > from simpc8313.c:26: > /home/r1aaha/git/u-boot/include/asm/config.h:28:1: warning: this is > the location of the previous definition > > which is probably all due to include/config.h including the file with > the default value prior to the board's config: > > /* Automatically generated - do not edit */ > #include <asm/config.h> > #include <configs/SIMPC8313.h> > > So how are boards supposed to define their own CONFIG_MAX_MEM_MAPPED > now? In the Makefile? Or is there a better place for this default > value?
We can probably swap the order of the generated config.h to have <asm/ config.h> be second. - k _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
