On Mon, 16 Feb 2009, Wolfgang Denk wrote:
> Dear k...@koi8.net,
>
> In message <pine.lnx.4.64ksi.0902121412060.21...@home-gw.koi8.net> you wrote:
> > Signed-off-by: Sergey Kubushyn <k...@koi8.net>
> > ---
> > diff -purN u-boot-i2c.orig/cpu/mpc8xx/video.c u-boot-i2c/cpu/mpc8xx/video.c
> > --- u-boot-i2c.orig/cpu/mpc8xx/video.c 2009-02-12 10:43:41.000000000
> > -0800
> > +++ u-boot-i2c/cpu/mpc8xx/video.c 2009-02-12 10:46:00.000000000 -0800
> > @@ -809,7 +809,11 @@ static void video_encoder_init (void)
> >
> > /* Initialize the I2C */
> > debug ("[VIDEO ENCODER] Initializing I2C bus...\n");
> > +#ifdef CONFIG_NEW_I2C
> > + i2c_init_all();
>
> As mentioned before, I think this is a design problem.
>
> You must not gloablly initialize all I2C busses / adapters.
>
> You are only permitted to initialize those devices that are actually
> needed by U-Boot itself to perform certain operations, and you are
> supposed to deactivate these after use.
What is wrong with activating ALL i2c adapters? Is there any viable reason
for this?
Then, please point me to a single board that deactivates an I2C adapter. And
please tell me what function one can use to do that. I haven't seen anything
like i2c_deinit() or i2c_disable().
---
******************************************************************
* k...@home KOI8 Net < > The impossible we do immediately. *
* Las Vegas NV, USA < > Miracles require 24-hour notice. *
******************************************************************
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
