On Monday 16 February 2009 15:54:06 Scott Wood wrote: > Mike Frysinger wrote: > > On Monday 16 February 2009 15:14:32 Wolfgang Denk wrote: > >> In message Mike Frysinger wrote: > >>>> As mentioned before, bd_info is a binary interfwace between U-Boot and > >>>> the Linux kernel, and it must not be changed. > >>> > >>> i'm not talking about changing the binary aspect of it. i'm talking > >>> about changing the API. two completely different things. > >> > >> Then I don't understand what you are talking about or what your patch > >> is doing. To me it looks as if you were removing the bi_enetaddr[] > >> resp. bi_enet?addr[] from the bd_info structure. > > > > the discussion has moved on. the original patch removed the fields, but > > in the follow ups it was proposed simply renaming them. please review > > the context of each reply. > > What do we gain from renaming them? We still need to fill in the MAC > addresses for compatibility. If you want to discourage new internal > users, use a comment (preferably a giant do-not-touch sign over the > entire bd_t).
people dont read comments. that method of deprecation is pure wishful thinking. people forward porting old code (boards/drivers/whatever) or even writing new code will build it up and if it seems to work, submit it. and no amount of review is 100% all the time. if, instead, they got a build error straight up front, they'd sure as hell figure out why and get it fixed. this is where a comment in the struct that says "this is legacy, do not touch, go read README.macaddr" would actually be read and be useful. -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
