On Thursday 29 January 2009 05:45:23 Wolfgang Denk wrote: > In message <1233212358-27956-1-git-send-email-vap...@gentoo.org> you wrote: > > Since the on-chip MAC does not have an eeprom or similar interface, force > > all Blackfin boards that use this to define their own > > board_get_enetaddr() function. > > I still think this belongs into board specific code, not into a > generic driver.
the driver isnt really generic. it's specific to the hardware that exists inside of Blackfin chips. the hardware has no support at all for storing the MAC in eeprom or any other place. thus it forces boards to declare some method for finding the MAC since there is literally no way for the hardware itself to do it. what you propose wouldnt have been possible before, but with Ben's work it should be easy to move to board_eth_init(). as for generic code, i'd point out that lib_ppc/board.c is a much worse offender in this regard ... -mike _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
