Dear Mark Jackson, In message <492a8d60.3090...@mimc.co.uk> you wrote: > Added code to setup the extra Flash and FRAM chip selects > as used on the MIMC200 board. > > Signed-off-by: Mark Jackson <m...@mimc.co.uk> > > --- > cpu/at32ap/cpu.c | 14 ++++++++++++++ > 1 files changed, 14 insertions(+), 0 deletions(-) > > diff --git a/cpu/at32ap/cpu.c b/cpu/at32ap/cpu.c > index 1a13702..3902efe 100644 > --- a/cpu/at32ap/cpu.c > +++ b/cpu/at32ap/cpu.c > @@ -56,6 +56,20 @@ int cpu_init(void) > hsmc3_writel(PULSE0, 0x0b0a0906); > hsmc3_writel(SETUP0, 0x00010002); > > +#ifdef CONFIG_MIMC200 > + /* setup Data Flash chip select (NCS2) */ > + hsmc3_writel(MODE2, 0x20121003); > + hsmc3_writel(CYCLE2, 0x000a0009); > + hsmc3_writel(PULSE2, 0x0a060806); > + hsmc3_writel(SETUP2, 0x00030102); > + > + /* setup FRAM chip select (NCS3) */ > + hsmc3_writel(MODE3, 0x10120001); > + hsmc3_writel(CYCLE3, 0x001e001d); > + hsmc3_writel(PULSE3, 0x08040704); > + hsmc3_writel(SETUP3, 0x02050204); > +#endif
I feel it is conceptually wrong to add board specific code to a common CPU specific file. Haavard, please comment? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Accident: A condition in which presence of mind is good, but absence of body is better. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
