Hi, Mike Frysinger wrote: > On Friday 02 January 2009 06:26:39 Jean-Christophe PLAGNIOL-VILLARD wrote: >> On 19:48 Thu 01 Jan , Mike Frysinger wrote: >>> From: Bryan Wu <bryan...@analog.com> >>> >>> The SanDisk Corporation U3 Cruzer Micro 1/4GB Flash Drive >>> 000016244373FFB4 does not like to be reset, so check for it. >>> >>> Signed-off-by: Bryan Wu <bryan...@analog.com> >>> Signed-off-by: Mike Frysinger <vap...@gentoo.org> >>> --- >>> common/usb_storage.c | 7 +++++++ >>> 1 files changed, 7 insertions(+), 0 deletions(-) >>> >>> diff --git a/common/usb_storage.c b/common/usb_storage.c >>> index 94f659f..94124f8 100644 >>> --- a/common/usb_storage.c >>> +++ b/common/usb_storage.c >>> @@ -1166,6 +1166,13 @@ int usb_stor_get_info(struct usb_device >>> *dev,struct us_data *ss,block_dev_desc_t /* SanDisk Corporation Cruzer >>> Micro 20044318410546613953 */ (dev->descriptor.idVendor == 0x0781 && >>> dev->descriptor.idProduct == 0x5151) >>> + || >>> + /* >>> + * SanDisk Corporation U3 Cruzer Micro 1/4GB >>> + * Flash Drive 000016244373FFB4 >>> + */ >>> + (dev->descriptor.idVendor == 0x0781 && >>> + dev->descriptor.idProduct == 0x5406) >>> ) >> instead of add more and more if else case >> why not add a fixup function? > > feel free to ask/take it up with the usb maintainer. we work with what's > there rather than being creative. > -mike > > ------------------------------------------------------------------------ > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > I sent a clean-up patch for the usb_storage few weeks ago ([U-Boot] [PATCH] USB storage cleanup patch), then I can carry on the fixup function too.
Michael _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
