On Thursday 11 December 2008 11:17:56 Kumar Gala wrote: > On Dec 11, 2008, at 4:32 AM, Mike Frysinger wrote: > > Rather than have the board code initialize SATA automatically during > > boot, > > make the user manually run "sata init". This brings the SATA > > subsystem in > > line with common U-Boot policy. > > > > Along these lines, the "is_sata_supported()" hook is no longer > > needed, so > > scrub it from the tree. > > > > Signed-off-by: Mike Frysinger <vap...@gentoo.org> > > --- > > board/freescale/mpc8536ds/mpc8536ds.c | 11 ----------- > > common/cmd_sata.c | 7 +++++-- > > include/sata.h | 2 -- > > lib_ppc/board.c | 20 -------------------- > > 4 files changed, 5 insertions(+), 35 deletions(-) > > Why should we make the user have to do 'sata init'? That seems > annoying and easy to forget.
it's already standard behavior with most mass storage things (like mmc and sf and ...), so it isnt a big deal imo. i asked if Wolfgang wanted it automated and he preferred making the user do it themselves. -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
