Hi Dave, On Thursday 20 November 2008, Dave Mitchell wrote: > Added include/asm-ppc/ppc4xx-isram.h and moved internal SRAM and > L2 cache DCRs from ppc440.h to this new header. > > Also converted these DCR defines from lowercase to uppercase and > modified referencing modules to use them.
Thanks, looks good. One nitpicking comment below though: > +++ b/include/asm-ppc/ppc4xx-isram.h > @@ -0,0 +1,75 @@ > + > +/* > + * See file CREDITS for list of people who contributed to this > + * project. > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, > + * MA 02111-1307 USA > + */ > + > +#ifndef _PPC4xx_ISRAM_H_ > +#define _PPC4xx_ISRAM_H_ > + > +/*------------------------------------------------------------------------ >----- >+ | Internal SRAM > + > +-------------------------------------------------------------------------- >--*/ I know that this comment style has been used in the "old" header bit please use the recommended multiline comment style now: /* * Comment */ Please fix and resubmit. Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
