Hello Stelian,
Stelian Pop wrote:
> Le mardi 21 octobre 2008 à 15:10 +0200, Ilko Iliev a écrit :
>
>> This patch allows to print custom strings on the LCD after the logo.
>>
>
> Hi Ilko,
>
>
>> Signed-off-by: Ilko Iliev <[EMAIL PROTECTED]>
>>
>> index d104b26..a94a4da 100644
>> --- a/common/lcd.c
>> +++ b/common/lcd.c
>> @@ -827,11 +827,19 @@ static void *lcd_logo (void)
>> sprintf (info, "%s", U_BOOT_VERSION);
>> lcd_drawchars (LCD_INFO_X, LCD_INFO_Y, (uchar *)info, strlen(info));
>>
>> - sprintf (info, "(C) 2008 ATMEL Corp");
>> +#ifndef CONFIG_LCD_LOGO_TEXT1
>> +# define CONFIG_LCD_LOGO_TEXT1 "(C) 2008 ATMEL Corp"
>> +#endif
>>
>
> Wouldn't it be better if we move this text into
> include/configs/at91xxx.h for all the boards ?
>
Yes, it will be better.
Because I'm a newbie in the U-BOOT development I didn't want to make
changes in all boards.
I have also other suggestions: see my email for the lowlevel_init.S
Do you know why the CPU registers are defined in this way:
#define AT91_PMC (0xfffffc00 - AT91_BASE_SYS)
This is OK for a C-code, but for an assembler it is a problem because
the following code gives an "Error: bad immediate value for offset":
ldr r1, =AT91_BASE_SYS
ldr r0, [r1, #AT91_PMC_MCKR]
regards,
Ilko Iliev
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
