Hi Kyungmin

What is the purpose of adding RB in UBI .

Rgs
Amit
----- Original Message ----- 
From: "Wolfgang Denk" <[EMAIL PROTECTED]>
To: "Kyungmin Park" <[EMAIL PROTECTED]>
Cc: <u-boot@lists.denx.de>
Sent: Monday, October 06, 2008 12:56 PM
Subject: Re: [U-Boot] [PATCH] Red Black Tree support


> Dear Kyungmin Park,
>
> In message <[EMAIL PROTECTED]> you wrote:
>> RB-tree support on U-Boot
>> Now it's used at UBI module. Of course other modules can 
>> use it.
> ...
>
> I understand the code is a verbatim copy from the LInux 
> kernel?
> Otherwise the coding style violations would not be 
> acceptable.
>
>> diff --git a/lib_generic/Makefile b/lib_generic/Makefile
>> index 7df5a2c..83b41ca 100644
>> --- a/lib_generic/Makefile
>> +++ b/lib_generic/Makefile
>> @@ -45,6 +45,7 @@ COBJS-y += string.o
>>  COBJS-y += strmhz.o
>>  COBJS-y += vsprintf.o
>>  COBJS-y += zlib.o
>> +COBJS-y += rbtree.o
>
> I expect that only few systems will actually use this, so 
> it must be
> configurable. It makes no sense to build this for ALL 
> systems. Please
> add a config option.
>
>
> Best regards,
>
> Wolfgang Denk
>
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & 
> Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 
> Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: 
> [EMAIL PROTECTED]
> Reader, suppose you were an idiot. And suppose you were a 
> member  of
> Congress. But I repeat myself.                           - 
> Mark Twain
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot 


_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to