On Wednesday 24 September 2008, Nobuhiro Iwamatsu wrote: > > BTW: I fail to see what's really PPC specific about the pci code in > > question. Nobuhiro, could you please elaborate what's the problem here? > > I wanted to remove CPU and baords of specific code from from PCI network > driver. CONFIG_E500, DB64360 and DB64460 CPU is PPC.
Now I understand. You are referring to code like this: drivers/net/eepro100.c: #if defined(CONFIG_E500) || defined(CONFIG_DB64360) || defined(CONFIG_DB64460) #define bus_to_phys(a) (a) #define phys_to_bus(a) (a) #else #define bus_to_phys(a) pci_mem_to_phys((pci_dev_t)dev->priv, a) #define phys_to_bus(a) pci_phys_to_mem((pci_dev_t)dev->priv, a) #endif > I thought that I could collect these with header files of PPC. > Therefore I sent that patch in RFC. Yes, it definitely is a good idea to move those defines to platform/cpu headers. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
