Dear Adam Graham,
In message <[EMAIL PROTECTED]> you wrote:
> Provide a weak defined routine to retrieve the CPU number for reference
> boards that have multiple CPU's. Default behavior is the existing single CPU
> print output. Reference boards with multiple CPU's need to provide a board
> specific routine. See boar
> d/amcc/arches/arches.c for an example.
>
> Signed-off-by: Adam Graham <[EMAIL PROTECTED]>
> Signed-off-by: Victor Gallardo <[EMAIL PROTECTED]>
>
> ---
> cpu/ppc4xx/cpu.c | 19 ++++++++++++++++++-
> 1 files changed, 18 insertions(+), 1 deletions(-)
>
> diff --git a/cpu/ppc4xx/cpu.c b/cpu/ppc4xx/cpu.c
> index bc9335a..71d4ad9 100644
> --- a/cpu/ppc4xx/cpu.c
> +++ b/cpu/ppc4xx/cpu.c
> @@ -41,6 +41,18 @@ DECLARE_GLOBAL_DATA_PTR;
>
> void board_reset(void);
>
> +/*
> + * To provide an interface to detect CPU number for boards that support
> + * more then one CPU, we implement the "weak" default functions here.
> + *
> + * Returns CPU number, else -1 if not known.
> + */
> +u32 __get_cpu_num(void)
> +{
> + return -1;
> +}
Returning "-1" when the function type is an unsigned? This makes
little sense to me.
> +u32 get_cpu_num(void) __attribute__((weak, alias("__get_cpu_num")));
> +
> #if defined(CONFIG_405GP) || \
> defined(CONFIG_440EP) || defined(CONFIG_440GR) || \
> defined(CONFIG_440EPX) || defined(CONFIG_440GRX)
> @@ -274,8 +286,13 @@ int checkcpu (void)
> #if !defined(CONFIG_IOP480)
> char addstr[64] = "";
> sys_info_t sys_info;
> + int cpu_num;
>
> - puts ("CPU: ");
> + cpu_num = get_cpu_num();
> + if (cpu_num >= 0)
get_cpu_num() return an unsigned ...
Please fix.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
"Once they go up, who cares where they come down? That's not my
department." - Werner von Braun
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
