Dear Graeme Russ, In message <[EMAIL PROTECTED]> you wrote: > Several minor corrections to allow clean builds of new i386 and sc520 > based boards based on 2008.10
Soory, but some parts of this cannot work: > --- a/examples/82559_eeprom.c > +++ b/examples/82559_eeprom.c > @@ -19,7 +19,6 @@ > */ > > #define _PPC_STRING_H_ /* avoid unnecessary str/mem functions > */ > -#define _LINUX_STRING_H_ /* avoid unnecessary str/mem functions */ Will this still build for other architectures, say ARM and MIPS and Power? > diff --git a/lib_i386/video_bios.c b/lib_i386/video_bios.c > index ce96a3e..1541773 100644 > --- a/lib_i386/video_bios.c > +++ b/lib_i386/video_bios.c > @@ -21,6 +21,8 @@ > * MA 02111-1307 USA > */ > > +#ifdef CONFIG_VIDEO > + > #include <common.h> > #include <pci.h> > #include <malloc.h> This cannot work. CONFIG_VIDEO can only be set in the board config file, which gets included implicitly by #include <common.h>, but you use the variable before that, so it will always be undefined, which is probably not what you intend. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] "...and the fully armed nuclear warheads, are, of course, merely a courtesy detail." _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
