Hi,
May I know the status of this patch back in mid-June? I haven't
seen it has been committed last time. I have two platforms that need
this driver. If not, I can re-send the patch again.
Thanks!
Regards,
TsiChung
-----Original Message-----
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of
Wolfgang Denk
Sent: Tuesday, June 10, 2008 5:02 AM
To: Jason McMullan
Cc: [EMAIL PROTECTED]
Subject: Re: [U-Boot-Users] [PATCH] SPI Flash: Support the
STMicroelectronics M25P80 and M25P40 SPI Flash
In message <[EMAIL PROTECTED]> you
wrote:
> This commit adds MTD support for the M25P80 (1Mx8) and the M25P40
> (512kx8) SPI Flash components from ST Microelectronics.
...
> --- /dev/null
> +++ b/drivers/mtd/spi/stmicro.c
> @@ -0,0 +1,326 @@
> +/*
> + * $Id$
> + *
Please remove these two lines.
> + do {
> + ret = spi_xfer(spi, 8, NULL, &status, 0);
> + if (ret)
> + return -1;
> +
> + if ((status & STMICRO_SR_WIP) == 0)
> + break;
> +
> + } while (1 || get_timer(timebase) < timeout);
Hm... the timeout code seems to be disabled here?
I think you should remove either the first or the second expression.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Mistakes are often the stepping stones to utter failure.
------------------------------------------------------------------------
-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for just about anything Open
Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
U-Boot-Users mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/u-boot-users
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
