Dear Ryan CHEN,
In message <[EMAIL PROTECTED]> you wrote:
> Hi Wolfgang,
> I have modified my patch according to your suggestion. The only question is
> that use debug() because I found all debug print msg lines are written as :
> #ifdef DEBUG
> printf(......);
> #endif
> Are you sure I need change my debug print to debug()?
Since all the other code is like that I agree to leave it unchanged.
But:
> @@ -66,6 +67,17 @@ extern int ext2fs_devread (int sector, int byte_offset,
> int byte_len,
^^^^^^^^^^^^^^
> @@ -226,10 +242,17 @@ static int ext2fs_read_inode
> printf ("ext2fs read inode blkno %d blkoff %d\n", blkno, blkoff);
> #endif
> /* Read the inode. */
> +#ifdef CFG_EXT2_SUPPORT_DYNAMIC_REV
> + status = ext2fs_devread (((__le32_to_cpu (blkgrp.inode_table_id) +
> + blkno) << LOG2_EXT2_BLOCK_SIZE (data)),
> + ext2_inode_size * blkoff,
> + sizeof (struct ext2_inode), (char *)
> inode);
^^^^^^^^^
> +#else
> status = ext2fs_devread (((__le32_to_cpu (blkgrp.inode_table_id) +
> blkno) << LOG2_EXT2_BLOCK_SIZE (data)),
> sizeof (struct ext2_inode) * blkoff,
> sizeof (struct ext2_inode), (char *)
> inode);
^^^^^^^^^
> +#endif
> if (status == 0) {
> return (0);
> }
> @@ -243,8 +266,13 @@ void ext2fs_free_node (ext2fs_node_t node,
> ext2fs_node_t currroot) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
etc.
Your patch is corrupted because your mailer wrapped long lines.
Please fix your mailer and repost (with a nice commit message,
please).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
In a survey taken several years ago, all incoming freshmen at MIT
were asked if they expected to graduate in the top half of their
class. Ninety-seven percent responded that they did.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
