Angus Robertson - Magenta Systems Ltd wrote:
>> Is there a special reason why methods ConnectFeatAsync and
>> ConnectFeatHostAsync are not executed with their own request types?
>> 
>> {* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
>> * * * * *}
>> procedure TCustomFtpCli.ConnectFeatAsync;           { V7.09 }
>> begin
>>     HighLevelAsync(ftpConnectAsync, // <= ftpConnectFeatAsync ?
>>                    [ftpFctOpen, ftpFctAuth, ftpFctUser, ftpFctPass,
>>                     ftpFctAcct, ftpFctFeat]);
>> end;
> 
> Simplicity perhaps, and backward compatibility.

Hmm, it's just confusing and wrong.

> These were new methods since ftpConnectAsync used to do FEAT but was
> causing problems with some old servers that could not cope with the
> command, so FEAT was removed and got it's own method.

I recall something like that, however removing FEAT from 
ConnectAsync was a _breaking change, so I do not understand how
a fake request type kept backward compatibility. 
Now in order to correct this we have to introduce a second 
breaking change :(

> 
> Adding ftpConnectFeatAsync would not mess up any of my applications.

It won't break mine as well, however the component has probably more
than two users. So I suggest to correct/break it in the beta branch
only (documented of course).   

-- 
Arno 
--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be

Reply via email to