I just downloaded recent version from SVN and found a strange define in 
OverbyteIcsDefs.inc
{$IFDEF CLR}
  {$DEFINE BOMB}
{$ELSE}
  {$IFNDEF COMPILER7_UP}
    {$DEFINE BOMB}
  {$ENDIF}
{$ENDIF}
It seems that it shouldn't really be CLR but old versions of BCB or something 
else.

And the second thing, I faced with Range check errors inside ICS code. After 
some investigations I've found the root of evil: _PostMessage in 
TCustomWSocket.Send takes wParam as Integer while FHSocket it is called with 
has unsigned type Cardinal. Casting FHSocket to Integer resolved the issue. 
There are several other places where socket handle is posted so I think they 
should be fixed too. And consider using WPARAM/LPARAM types for casting instead 
of general integer ones for higher compatibility.
Moreover, after I've learned some thing regarding x64 I accepted the habit of 
sending/posting pointers/handles ONLY in LParam which is what it intended for. 
So it'd be nice to see it in ICS.

-- 
Anton
--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be

Reply via email to