Maurizio Lotauro wrote: > Scrive Arno Garrels <[EMAIL PROTECTED]>: > >> Maurizio Lotauro wrote: > > [...] > >> Just tested you code, so far it is working smoothly, good job! > > Thank you :-) > >> However, I changed the string-type of new properties ServerAuth as well >> as ProxyAuth to a new custom type: >> THttpAuthType = (httpAuthNone, httpAuthBasic, httpAuthNtlm); >> This is much better practice and also faster because a lot of calls to >> CompareStr() can be exchanged by faster checks (i.e. if FProxyAuth <> >> httpAuthNone then), >> any veto? > > No please keep they as string for two reasons: > - if someone implement another authentication in an inherited compnent > he/her must change HttpProt.pas to add a new item to the set
Hmm, but that's how it is done in ICS since the beginning. I also don't think that there will be lots of new auth-types in the future, and a new item is added in a few milliseconds, however string comparisons are terrible slow. > - I already have a version of HttpCli that implement the authentication > in a different way (like the beta of content conding). It use a > registration class mechanism to let know the component what kind of > authentication are available. > > It is like other properties (Connection for example) where practically > they can contain only specific values but actualy you can specify > whatever you want. It is developer responsability to set they to a proper > value. I already have merged the above changes and sent V4c to Francois, it's no problem to revert them back to string type, Francois? -- To unsubscribe or change your settings for TWSocket mailing list please goto http://www.elists.org/mailman/listinfo/twsocket Visit our website at http://www.overbyte.be
