On 2021-03-01 19:25, Craig Rodrigues wrote:

On Mon, Mar 1, 2021 at 3:27 PM Kyle Altendorf <s...@fstab.net> wrote:

On 2021-03-01 14:13, Craig Rodrigues wrote:

On Mon, Mar 1, 2021 at 9:13 AM Colin Watson <cjwat...@debian.org>
wrote:

Isn't this just because incremental hasn't had a release since 17.5.0?
I added post= support way back in
https://github.com/twisted/incremental/pull/37, but that was after
17.5.0.

Oh wow!  You are right.

Can someone help me release a new version of Twisted incremental?
I don't know how to do it.

I would have expected the existing PRs could be handled and that the
release would have a release branch with a towncrier run and review.

https://github.com/twisted/incremental/pull/67

Kyle,

Yes, I did PR 67 in incremental just now. I have write access to the twisted/incremental Git repo.

My point was that you missed a review and you missed running towncrier and depending what release process you are following you missed a tag in the branch and a post-release-version-change. You asked about how to release but gave no time for response.

Cheers,
-kyle

_______________________________________________
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Reply via email to