On 2019-08-11 15:31, Ant wrote:
Hello.
I cannot figure out how to report this minor bug of a minor upgrade
issue (https://github.com/twisted/twisted didn't have an issues
section) that I noticed since last week:
$ pip list --outdated DEPRECATION: Python 3.4
support has been deprecated. pip 19.1 will be the last one supporting
it. Please upgrade your Python as Python 3.4 won't be maintained after
March 2019 (cf PEP 429).
Package Version Latest Type
------- ------- ------ -----
Twisted 19.2.1 19.7.0 sdist
$ pip install --upgrade Twisted
DEPRECATION: Python 3.4 support has been deprecated. pip 19.1 will be
the last one supporting it. Please upgrade your Python as Python 3.4
won't be maintained after March 2019 (cf PEP 429).
Collecting Twisted
Using cached
https://files.pythonhosted.org/packages/61/31/3855dcacd1d3b2e60c0b4ccc8e727b8cd497bd7087d327d81a9f0cbb580c/Twisted-19.7.0.tar.bz2
ERROR: Complete output from command python setup.py egg_info:
ERROR: Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/tmp/pip-install-2h_su73e/Twisted/setup.py", line 20, in
<module>
setuptools.setup(**_setup["getSetupArgs"]())
File "<string>", line 257, in getSetupArgs
File "<string>", line 208, in _checkPythonVersion
ImportError: Twisted on Python 3 requires Python 3.5 or later.
----------------------------------------
ERROR: Command "python setup.py egg_info" failed with error code 1 in
/tmp/pip-install-2h_su73e/Twisted/
That v19.7.0 shouldn't even be offered for my outdated setups. :(
Perhaps a `python_requires=` would do the trick?
https://github.com/twisted/twisted/blob/c55c778e6c7a758cb9cee568a9188ac49e628c27/src/twisted/python/_setup.py#L54-L75
Maybe: python_requires='>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*!=3.4.*'
And perhaps also drop the manual checking code?
I'm kind of busy but if someone else doesn't get to it first I'll try to
get to a ticket/PR later.
Cheers,
-kyle
_______________________________________________
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
