This looks like a straightforward bug to me. I don't see any reason we can't change the implementation to either raise TypeError immediately or accept a string, since any code that passes a string doesn't work right now. Would you file a bug at https://twistedmatrix.com/trac/newticket?
---Tom -- Tom Most t...@freecog.net On Mon, May 20, 2019, at 12:22 AM, Thomas Westfeld wrote: > Dear all, > > I just migrated some quite basic twisted code from Python 2.7 to Python > 3. Everything worked quite nicely, the main issue was the correct > handling of strings vs. bytes. > > There was a mean error I made when using the Twisted Agent http client: > I specified the method as a Unicode string, instead of using > Agent.request(b'GET',b'http://whatever.com'). The mean thing is that > the code does not produce any error. It connects to the server via TCP > but then stops. > > It is given correctly in the examples of the docs and also in the > source code, but wouldn't it make things easier to make a type check in > the request method if the method parameter is of type Unicode and raise > an error? > > Best regards, > Thomas Westfeld > _______________________________________________ > Twisted-Python mailing list > Twisted-Python@twistedmatrix.com > https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python > _______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
