> On Nov 27, 2018, at 2:37 PM, Jeff Grimmett <grimmto...@gmail.com> wrote:
> 
> Thanks, Tom.  
> 
> Is there a limit to the smallness of the proposed changes?  For example, if I 
> had a possible two-line change to 
> https://twistedmatrix.com/documents/current/api/twisted.internet.wxreactor.html
>  
> <https://twistedmatrix.com/documents/current/api/twisted.internet.wxreactor.html>
>  (which looks like it would be done in the docstring), is it okay to just 
> have a PR for that or does it need to be bundled with more changes?
> 
> Thanks,
> 
> Jeff 

Smaller changes are always better!  Sometimes changes need to be larger and 
don't make sense when split up, so it's OK to propose large things, but a 
one-liner is the easiest possible thing to review, and will generally get 
integrated faster.

-g
_______________________________________________
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Reply via email to