On 2016-12-29, at 12:23, Glyph Lefkowitz <gl...@twistedmatrix.com> wrote: > >> On Dec 27, 2016, at 19:15, ex vito <ex.vitor...@gmail.com> wrote: >> >> Other than looking for confirmation, I have a fix which I included two >> isolated commits in the PR. Twisted project members: if this is confirmed, >> maybe a ticket should be created in Trac and an independent PR created, >> correct? > > You should definitely create that ticket. In fact, you don't need to wait > for confirmation - create the ticket now, and send the link to it, so someone > else can comment on the ticket when it is confirmed - discussion of the > reproduction process can happen there.
Done, Ticket: https://twistedmatrix.com/trac/ticket/8969 PR: https://github.com/twisted/twisted/pull/650 Up for review with a guidance request on how to achieve 100% diff coverage given that different platforms behave differently with the same input. Thanks and regards, -- exvito
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
